Fixed Load LEO Sats for Date changes the date -1, loads sats for date +1

[R2robot]

In this example I started a new sitch and set the date to 12/13/2024. When I load leo sats, the date changes back one day to the 12th and the TLEs loaded say the 14th.



https://www.metabunk.org/sitrec/?cu...018/leo sat date weirdness/20251125_064517.js

 

[Mick West]

Fixed!

That's an embarrassing bug. It looks like it's been there for two weeks. I hope it has not caused too much confusion.

Spoiler: Technical

The root cause was using the global dateStart date object by reference when I should have used a copy. It was slightly more subtle as I was previously using the global dateNow object by reference, which was also wrong, but worked fine as it was dynamically updated from dateStart. But when I changed to dateStart, it started to cause problems. This old occurred for times more that 48 hours before the real time, so would not always happen

 

[FatPhil]

World-writable members? That's asking for the mistake to happen again. Encapsulation is your friend (and one of the original features of object-oriented languages, it was the point of them, so whatever this lanuage is, it was a half-baked language design).

 

[R2robot]

Fixed!

... I hope it has not caused too much confusion.

Not too much.. Thank you!

 

[Mick West]

World-writable members? That's asking for the mistake to happen again. Encapsulation is your friend (and one of the original features of object-oriented languages, it was the point of them, so whatever this lanuage is, it was a half-baked language design).

It's Javascript, so yes.